Conversation
Contributor
jdx
commented
Nov 24, 2015
jdx
commented
jdx
force-pushed
the
sso
branch
5 times, most recently
from
80a770d to
6234cd9
Compare
There was a problem hiding this comment.
Should this default to $HEROKU_ORGANIZATION?
There was a problem hiding this comment.
I guess this comment should really be about line 38 when the org value is initialized.
|
👍 |
jdx
force-pushed
the
sso
branch
2 times, most recently
from
e37bf08 to
fe00724
Compare
Contributor
|
Nice!, thanks @dickeyxxx |
jdx
force-pushed
the
sso
branch
2 times, most recently
from
3c6a7d3 to
b025165
Compare
Contributor
Author
|
changes are up, ready for review @raulb |
Contributor
|
@dickeyxxx 👍 , thanks! Let me know when this is ready in production, and I'll get rid of https://github.com/heroku/heroku-sso. |
jdx
pushed a commit
that referenced
this pull request
Nov 30, 2015
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.